Fix the issue where Patch objects cannot be updated via set_props() in WebSocket callbacks#3759
Open
CNFeffery wants to merge 7 commits intoplotly:websocket-callbacksfrom
Open
Fix the issue where Patch objects cannot be updated via set_props() in WebSocket callbacks#3759CNFeffery wants to merge 7 commits intoplotly:websocket-callbacksfrom
CNFeffery wants to merge 7 commits intoplotly:websocket-callbacksfrom
Conversation
CNFeffery
requested review from
KoolADE85,
T4rk1n,
camdecoster and
ndrezn
as code owners
Contributor
Author
|
Based on the functional demonstration results of the local development version 
Core callback function code: @app.callback(
Input("load-stream-content", "nClicks"),
websocket=True,
running=[[Output("load-stream-content", "loading"), True, False]],
)
async def load_stream_content(nClicks):
for s in test_markdown:
await asyncio.sleep(0.02)
p = Patch()
p += s
set_props("markdown-content", {"markdownStr": p}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new websocket callback mechanism introduced starting from version
4.2.0rc1currently does not allow updating Patch objects viaset_props()within websocket-type callbacks. This PR fixes the aforementioned issue. Closes #3758